On 04/22/2013 08:16 AM, Martin Kosek wrote:
> On 04/19/2013 04:58 PM, Rob Crittenden wrote:
>> Ana Krivokapic wrote:
>>> On 04/19/2013 03:58 PM, Rob Crittenden wrote:
>>>> Rob Crittenden wrote:
>>>>> Ana Krivokapic wrote:
>>>>>> Hello,
>>>>>>
>>>>>> Make sure /etc/ipa is created and owned by freeipa-python package.
>>>>>>
>>>>>> Report correct error to user if /etc/ipa is missing during client
>>>>>> installation.
>>>>>>
>>>>>> https://fedorahosted.org/freeipa/ticket/3551
>>>>> The server also owns this directory. It should only be owned by the
>>>>> python subpackage.
>>>>>
>>>>> %dir %{_sysconfdir}/ipa
>>>>>
>>>>> rob
>>>> The mode should probably be 0755.
>>>>
>>>> rob
>>>>
>>> Thanks, fixed.
>>>
>> ACK. pushed to master and ipa-3-1
>>
>> rob
>>
> Hm, the spec change does not look right to me:
>
> +%dir %attr(0755,root,apache) %config(noreplace) %{_sysconfdir}/ipa/
>
> Why is the directory owned by group apache? Why does the directory have
> "%config(noreplace)" set? Isn't it a NOOP when set for a directory (just
> asking)?
>
> This is what we get when we install freeipa-python now:
>
> # rm -r /etc/ipa/
> # rpm -Uvh --force
> /home/mkosek/dist-master/rpms/freeipa-client-3.2.0GIT2a8f1b0-0.fc18.x86_64.rpm
> /home/mkosek/dist-master/rpms/freeipa-python-3.2.0GIT2a8f1b0-0.fc18.x86_64.rpm
>
> # ll -d /etc/ipa/
> drwxr-xr-x. 2 root apache 4096 Apr 22 02:05 /etc/ipa/
> ^^^^^^
> Thanks,
> Martin
You are right, it was a mistake on my part. Attached is a oneliner fix.
--
Regards,
Ana Krivokapic
Associate Software Engineer
FreeIPA team
Red Hat Inc.
From a7e4d3ac8b5ffb75703b9d026ff7ec00543d4855 Mon Sep 17 00:00:00 2001
From: Ana Krivokapic <akriv...@redhat.com>
Date: Mon, 22 Apr 2013 11:22:42 +0200
Subject: [PATCH] Fix the spec file
Correct ownership for /etc/ipa and remove unnecessary %config directive.
---
freeipa.spec.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/freeipa.spec.in b/freeipa.spec.in
index bf53a3de42e2e941daddb7c83f42b17699aa4b00..af3fb374394f5192849cff147ace50c51d2bb90d 100644
--- a/freeipa.spec.in
+++ b/freeipa.spec.in
@@ -789,7 +789,7 @@ fi
%{python_sitelib}/ipapython-*.egg-info
%{python_sitelib}/freeipa-*.egg-info
%{python_sitearch}/python_default_encoding-*.egg-info
-%dir %attr(0755,root,apache) %config(noreplace) %{_sysconfdir}/ipa/
+%dir %attr(0755,root,root) %{_sysconfdir}/ipa/
%ghost %attr(0644,root,apache) %config(noreplace) %{_sysconfdir}/ipa/default.conf
%ghost %attr(0644,root,apache) %config(noreplace) %{_sysconfdir}/ipa/ca.crt
--
1.8.1.4
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
