On 04/08/2013 07:45 PM, Petr Spacek wrote: > Hello, > > Generalize attribute_name<->rdata_type conversions. > > Attribute names are generated on-the-fly: String "Record" is appended > to textual representation of DNS RDATA type. > > String "Record" is cut down from the attribute name during > attribute name to rdata type conversion. > > From now, the plugin doesn't add artificial limitation to supported > record types.
ACK. The patch looks good. (I didn't do functional test) Cosmetic issue: I think it would be good to dynamically allocate "mod_type" in LDAPMod in every case and include the "mod_type" memory freeing in free_ldapmod() function. Now one has to be be careful when it is statically or dynamically allocated. Before it was static in every case. Regards, Tomas Hozza _______________________________________________ Freeipa-devel mailing list Freeipaemail@example.com https://www.redhat.com/mailman/listinfo/freeipa-devel