Unsubscribe On May 15, 2013 12:01 PM, <freeipa-devel-requ...@redhat.com> wrote:
> Send Freeipa-devel mailing list submissions to > freeipa-devel@redhat.com > > To subscribe or unsubscribe via the World Wide Web, visit > https://www.redhat.com/mailman/listinfo/freeipa-devel > or, via email, send a message with subject or body 'help' to > freeipa-devel-requ...@redhat.com > > You can reach the person managing the list at > freeipa-devel-ow...@redhat.com > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of Freeipa-devel digest..." > > > Today's Topics: > > 1. Re: [PATCH] 0026 Do not display success message on failure in > web UI (Ana Krivokapic) > > > ---------------------------------------------------------------------- > > Message: 1 > Date: Wed, 15 May 2013 17:43:28 +0200 > From: Ana Krivokapic <akriv...@redhat.com> > To: Petr Vobornik <pvobo...@redhat.com> > Cc: freeipa-devel <freeipa-devel@redhat.com> > Subject: Re: [Freeipa-devel] [PATCH] 0026 Do not display success > message on failure in web UI > Message-ID: <5193ad20.1050...@redhat.com> > Content-Type: text/plain; charset="iso-8859-1" > > On 05/13/2013 04:51 PM, Petr Vobornik wrote: > > On 05/07/2013 05:16 PM, Ana Krivokapic wrote: > >> https://fedorahosted.org/freeipa/ticket/3591 > >> > > > > 1) The change from on_success to on_error is causing problems when > > some command in a batch doesn't fail. Ie.: disable multiple users on > > user search facet. Disabling already disabled user causes an error. > > The dialog is shown but the page is not refreshed so the newly > > disabled records are still displayed as enabled. We might even call > > this case a success. > > > > IMO we shouldn't change the method because the batch itself succeeded. > > The problem should be fixed on caller side (users of batch command). > > > > 2) Also `ajax` context should be left there instead of `this`, > > otherwise it would get the context of on_ok handler: > > > > 3) (not an actual issue) Some of my old code doesn't contain space > > between for/if and opening curly bracet, opposite to the rest of the > > Web UI. Spaces should be added when touching these parts of code. > > Since the problem occurs in the case when the batch succeeds, but some > commands from the batch fail, it should be enough to modify the message > that is displayed. I modified it so it shows exactly how many items from > the batch succeeded. > > Updated patch is attached. > > -- > Regards, > > Ana Krivokapic > Associate Software Engineer > FreeIPA team > Red Hat Inc. > > -------------- next part -------------- > A non-text attachment was scrubbed... > Name: > freeipa-akrivoka-0026-02-Do-not-display-success-message-on-failure-in-web-UI.patch > Type: text/x-patch > Size: 2849 bytes > Desc: not available > URL: < > https://www.redhat.com/archives/freeipa-devel/attachments/20130515/67c3a9c8/attachment.bin > > > > ------------------------------ > > _______________________________________________ > Freeipa-devel mailing list > Freeipa-devel@redhat.com > https://www.redhat.com/mailman/listinfo/freeipa-devel > > End of Freeipa-devel Digest, Vol 72, Issue 51 > ********************************************* >
_______________________________________________ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel