On 05/17/2013 04:11 PM, Petr Viktorin wrote:
> Hello,
> The IPA test suite currently fails on f19 due to Camellia cipher that we don't
> enable by default. This makes the test ignore extra warnings on 
> ipa-getkeytab's
> stderr.
> 
> 
> Note: I've skipped triage for this ticket because it's interfering with 
> getting
> a CI server set up (#3621).

ACK. Before pushing, please also consider for ack&pushing attached patch. It
will fix this test on Fedora 19 instances where DIR CCACHE is a default type of
CCACHE.

Thanks,
Martin
From a283206b412c38f844337b1e57f791c60317dd7c Mon Sep 17 00:00:00 2001
From: Martin Kosek <mko...@redhat.com>
Date: Wed, 22 May 2013 12:26:55 +0200
Subject: [PATCH] Handle DIR type CCACHEs in cmdline properly

Pass a whole krbV.CCache object to ldap2 connect() method so that
it can properly detect both type and name of a CCAHE. Otherwise
the test fails on systems with default DIR type CCACHE.
---
 tests/test_cmdline/cmdline.py           | 2 +-
 tests/test_cmdline/test_ipagetkeytab.py | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/test_cmdline/cmdline.py b/tests/test_cmdline/cmdline.py
index 1df6a7cce759224a20270da5f16069fc28559e38..d86652bd12f805da3c39678ee3f4ff1cf40a3b01 100644
--- a/tests/test_cmdline/cmdline.py
+++ b/tests/test_cmdline/cmdline.py
@@ -31,7 +31,7 @@
 from ipapython import ipautil
 
 # See if our LDAP server is up and we can talk to it over GSSAPI
-ccache = krbV.default_context().default_ccache().name
+ccache = krbV.default_context().default_ccache()
 
 try:
     conn = ldap2(shared_instance=False, ldap_uri=api.env.ldap_uri, base_dn=api.env.basedn)
diff --git a/tests/test_cmdline/test_ipagetkeytab.py b/tests/test_cmdline/test_ipagetkeytab.py
index b894cea44da5c905f6b181622a78a4027d180cf7..cb46fd23bf320f59c30e53ceaa85d09aa7a3e2b4 100644
--- a/tests/test_cmdline/test_ipagetkeytab.py
+++ b/tests/test_cmdline/test_ipagetkeytab.py
@@ -46,7 +46,7 @@ def use_keytab(principal, keytab):
         ccache.init(principal)
         ccache.init_creds_keytab(keytab=keytab, principal=principal)
         conn = ldap2(shared_instance=False, ldap_uri=api.env.ldap_uri, base_dn=api.env.basedn)
-        conn.connect(ccache=ccache.name)
+        conn.connect(ccache=ccache)
         conn.disconnect()
     except krbV.Krb5Error, e:
         raise StandardError('Unable to bind to LDAP. Error initializing principal %s in %s: %s' % (principal.name, keytab, str(e)))
-- 
1.8.1.4

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to