On 06/13/2013 03:24 PM, Petr Vobornik wrote: > On 06/13/2013 02:46 PM, Ana Krivokapic wrote: >> On 06/13/2013 12:30 PM, Petr Vobornik wrote: >>> Rule tables with external member has more than one column and >>> therefore exclude parameter for adder dialog is not array of strings >>> but array of objects. normalize_values function can't work with it and >>> causes JS error. >>> >>> This patch creates proper exclude array before passing it to adder >>> dialog. >>> >>> https://fedorahosted.org/freeipa/ticket/3711 > >> ACK >> >> > > I've noticed that there is a leftover from a different approach: > > pkey: pkey, > + param: that.name, > other_entity: that.other_entity, > > The line is removed, updated patch attached. > > > _______________________________________________ > Freeipa-devel mailing list > Freeipa-devel@redhat.com > https://www.redhat.com/mailman/listinfo/freeipa-devel
I missed it too in the first patch. ACK for updated patch. -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc.
_______________________________________________ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
