Hello,
Fix crash during zone_refresh triggered by connection failure.
Variable 'iter' was initialized too late. Code in cleanup section of
refresh_zones_from_ldap() dereferenced the uninitialized variable.
--
Petr^2 Spacek
From 3affa9c2431928a5b5708875ab937d598059561e Mon Sep 17 00:00:00 2001
From: Petr Spacek <pspa...@redhat.com>
Date: Mon, 15 Jul 2013 15:08:01 +0200
Subject: [PATCH] Fix crash during zone_refresh triggered by connection
failure.
Variable 'iter' was initialized too late. Code in cleanup section of
refresh_zones_from_ldap() dereferenced the uninitialized variable.
Signed-off-by: Petr Spacek <pspa...@redhat.com>
---
src/ldap_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/ldap_helper.c b/src/ldap_helper.c
index 05aa1a1d4b5091816af092895e881c0e2b1ff0eb..d0286af6c6e6e0084386ae5d1fe4e2ebb2954d4a 100644
--- a/src/ldap_helper.c
+++ b/src/ldap_helper.c
@@ -1632,6 +1632,7 @@ refresh_zones_from_ldap(ldap_instance_t *ldap_inst, isc_boolean_t delete_only)
dns_rbt_t *forward_rbt = NULL; /** < Forward zones only */
isc_boolean_t psearch;
const char *base = NULL;
+ rbt_iterator_t *iter = NULL;
char *config_attrs[] = {
"idnsForwardPolicy", "idnsForwarders",
"idnsAllowSyncPTR", "idnsZoneRefresh",
@@ -1729,7 +1730,6 @@ refresh_zones_from_ldap(ldap_instance_t *ldap_inst, isc_boolean_t delete_only)
/* Walk through master zone register and remove all zones which
* disappeared from LDAP. */
- rbt_iterator_t *iter = NULL;
char name_txt[DNS_NAME_FORMATSIZE];
DECLARE_BUFFERED_NAME(registered_name);
DECLARE_BUFFERED_NAME(ldap_name);
--
1.8.3.1
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
