Hi,

On 17.7.2013 16:38, Ana Krivokapic wrote:
Hello,

This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3785.


NACK, this results in an unnecessarily ugly error message "[Errno 2] No such file or directory: 'file'".

I would suggest something like this instead:

except IOError as e:
    raise ScriptError("Failed to open %s: %s" % (ca_cert_name, e.strerror))

Can you please also check what happens if you pass non-existent filename to --dirsrv_pkcs12 and --http_pkcs12?

Honza

--
Jan Cholasta

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to