On 07/25/2013 12:28 PM, Jan Cholasta wrote:
On 25.7.2013 12:23, Petr Viktorin wrote:
On 07/24/2013 03:46 PM, Petr Viktorin wrote:
On 07/24/2013 02:39 PM, Jan Cholasta wrote:
On 17.7.2013 14:45, Petr Viktorin wrote:
On 07/16/2013 05:25 PM, Petr Viktorin wrote:
This exposes tasks such as installation, uninstallation, clean-up
should
be available as CLI commands so they're available for non-Python
tests.

https://fedorahosted.org/freeipa/ticket/3721

It also allows tests to install IPA in a specific topology by setting
the `topology` attribute to 'star', 'line', 'tree', etc. (so far only
'star' or none was supported).

The first patches contain some refactoring/enhancements needed to
make
this possible.


I found a bug in patch 0246 and a typo in 0249. This update fixes
them.


Patch 245:

Since you use tar -J, I think it might make sense to add tar and xz to
freeipa-tests requires.

Thanks for the catch. That patch just moves the code around, it doesn't
introduce the dependencies.
Here's a separate patch to change the spec file.

Rebased to current master.

OK, thanks!


Otherwise it looks good to me.

Thanks for the review


ACK.

Honza


Pushed to master: e38816bdaf2280e283df6c2746897c37fa3bbb92

--
PetrĀ³

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to