On 08/20/2013 06:19 PM, Nathaniel McCallum wrote:
> On Tue, 2013-08-20 at 15:56 +0200, Petr Vobornik wrote:
>> On 08/19/2013 05:33 PM, Petr Vobornik wrote:
>>> https://fedorahosted.org/freeipa/ticket/3834
>>>
>> New version. Fixes usage of secondary rid for non-trust installation.
> A lot of the functions have spaces between the function declaration an
> the first line. I don't know how strictly we follow PEP8, but I thought
> I'd point it out.
>
> Nathaniel
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel

A general rule is that we _try_ to make any new code PEP8 compliant, as well as
make appropriate fixes when refactoring old code.

Personally, I don't have a problem with a few blank lines. Technically, I don't
think this is a PEP8 violation as blank lines are allowed inside functions.

The patch works fine and I have no objections to the code, so ACK from me.

-- 
Regards,

Ana Krivokapic
Associate Software Engineer
FreeIPA team
Red Hat Inc.

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to