On 09/04/2013 03:28 PM, Ana Krivokapic wrote:
On 09/03/2013 01:15 PM, Petr Viktorin wrote:
On 09/02/2013 05:05 PM, Ana Krivokapic wrote:

This patch addresses tickethttps://fedorahosted.org/freeipa/ticket/3797.

Thanks! I have a question.

-        # retry several times -- logic follows /etc/init.d/ntpdate
-        # implementation
+        # retry several times
           for retry in range(0, 3):

What's the reason to try several times? Is it still necessary with ntpd?
I checked /etc/init.d/ntpdate in RHEL (since Fedora doesn't have it any more)
and I didn't see any repeating.

I am not sure what the reason for trying several times was. My testing didn't
reveal any need for that, but I left the code there mainly because it returns
immediately after successful sync, so there is no harm.

Attached is a version of the patch without the repetition.

Thanks, ACK, pushed to master: 28144e358c38e1c27eeb332b02d8470f18913af6


Freeipa-devel mailing list

Reply via email to