On 10/11/2013 02:57 PM, Jérôme Fenal wrote:
> 2013/10/11 Martin Kosek <mko...@redhat.com>:
>> On 10/10/2013 06:37 PM, Jérôme Fenal wrote:
>>> Replaced the dodgy sentence with Martin's one.
>> Thanks Jérôme for the patch, I have few comments though:
>> 1) One more note for patch format, please use the following command to
>> your patch from git:
>> $ git format-patch -M -C --patience --full-index -1
>> Source: http://www.freeipa.org/page/Contribute/Patch_Format
>> It will maker then easier for us to merge the patch to main git tree.
>> 2) I think we should not mix indentation with spaces and tabs
> Switched back to noet in vim, and fixed.
>> 3) Shouldn't we also remove the now redundant previous paragraph? A change
>> - <para>
>> - A specific user or host can be removed from
>> SELinux map by using either the <command>selinuxusermap-remove-host</command>
>> or <command>selinuxusermap-remove-user</command> comma...
>> - </para>
> Done as well, working while tired on doc cannot be spotted by a compiler... :)
> Let me know.
Thanks Jérôme, the patch is perfect now. Unfortunately I see that I cannot push
it as Martin Basti's commit 0d48ee15 already fixes this spot.
But please don't be afraid, there will be many other opportunities to use the
newly gained FreeIPA-doc-contribution skill :)
Thanks for help,
Freeipa-devel mailing list