On 10/15/2013 06:19 PM, Jérôme Fenal wrote:
> kk2013/10/15 Martin Kosek <mko...@redhat.com>:
>> Thanks. It would be ideal, if this table is (in future) generated somehow
>> semi-automatically as practically all this info can be gathered from FreeIPA
>> code. But for now, this is great.
>>
>> I see some issues with the patch though:
>>
>> 1) Whitespaces before tabs
> 
> OK, I fixed my attached script my removing leading spaces in the
> second part of s///.
> 
>> I fixed some of them with
>> sed -i "s/\+\t$/+/g" 
>> /tmp/freeipa-jfenal-0003-Split-commands-in-proper-tables.patch
>>
>> Bug there is the second issue:
>>
>> 2) Test&build fails:
>>
>> $ git am /tmp/freeipa-jfenal-0003-Split-commands-in-proper-tables-1.patch
>> Applying: Split commands in proper tables
>> /home/mkosek/freeipa-docs/.git/rebase-apply/patch:211: space before tab in 
>> indent.
>>                                                 <row>
>> /home/mkosek/freeipa-docs/.git/rebase-apply/patch:212: space before tab in 
>> indent.
>>                                                         <entry>
>> /home/mkosek/freeipa-docs/.git/rebase-apply/patch:213: space before tab in 
>> indent.
>>                                                                  
>> automountkey-add
>> /home/mkosek/freeipa-docs/.git/rebase-apply/patch:214: space before tab in 
>> indent.
>>                                                         </entry>
>> /home/mkosek/freeipa-docs/.git/rebase-apply/patch:215: space before tab in 
>> indent.
>>                                                         <entry>
>> warning: squelched 1849 whitespace errors
>> warning: 1854 lines add whitespace errors.
> 
> Will look into that.
> 
> Side question, how did you get the initial text command list?

This is a work that Deon did, not sure if she used some automated way though...

Martin

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to