On 10/24/2013 04:38 PM, Tomas Babej wrote:
On 10/24/2013 01:29 PM, Petr Viktorin wrote:
[...]


Patch 106:

In ADTrustBase, it looks like if test_install_adtrust or
test_configure_dns_and_time fail, it doesn't make much sense to run
the other tests.
If that's the case they can go in an install() classmethod. Same with
test_establish_trust* in the subclasses.

I made them part of the install() classmethod.

As for the test_estabilish_trust, I would have to still override that in
each class that uses it, since all of them use it in a slightly
different way.

I'd prefer an "establish_trust" classmethod called from install(), but it's not really important in this case.

Also, there's a typo in test_estabilish_trusts several times.
                             -----^----


Typo fixed. Also attaching a patch that fixes the same type in the other
parts of the codebase.


ACK, ACK, pushed to
master: df5f5c9fab5dd66c50bf202e1ebd19f558e3e0c6
ipa-3-3: 5dbd11722e365f50b7496b4ab2559122cd927d53

Thanks for your patience!

--
PetrĀ³

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to