On 10/29/2013 04:17 PM, Petr Viktorin wrote:
[...]
106 - 121: ACK
I've either rushed review, or introduced a conflict with my ACI
refactors. It turns out patch 112 broke a permission plugin test:
======================================================================
FAIL: test_permission[22]: permission_find: Search for permissions by
attr with a limit of 1 (truncated)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose/case.py", line 197, in
runTest
self.test(*self.arg)
File "/home/pviktori/freeipa/ipatests/test_xmlrpc/xmlrpc_test.py",
line 283, in <lambda>
func = lambda: self.check(nice, **test)
File "/home/pviktori/freeipa/ipatests/test_xmlrpc/xmlrpc_test.py",
line 301, in check
self.check_output(nice, cmd, args, options, expected, extra_check)
File "/home/pviktori/freeipa/ipatests/test_xmlrpc/xmlrpc_test.py",
line 341, in check_output
assert_deepequal(expected, got, nice)
File "/home/pviktori/freeipa/ipatests/util.py", line 344, in
assert_deepequal
assert_deepequal(e_sub, g_sub, doc, stack + (key,))
File "/home/pviktori/freeipa/ipatests/util.py", line 332, in
assert_deepequal
assert_deepequal(e_sub, g_sub, doc, stack + (i,))
File "/home/pviktori/freeipa/ipatests/util.py", line 338, in
assert_deepequal
doc, sorted(missing), sorted(extra), expected, got, stack
AssertionError: assert_deepequal: dict keys mismatch.
test_permission[22]: permission_find: Search for permissions by attr
with a limit of 1 (truncated)
missing keys = ['memberindirect_role']
extra keys = []
expected = {'dn': ipapython.dn.DN('cn=Modify HBAC
rule,cn=permissions,cn=pbac,dc=idm,dc=lab,dc=eng,dc=brq,dc=redhat,dc=com'),
'cn': [u'Modify HBAC rule'], 'member_privilege': [u'HBAC
Administrator'], 'subtree':
u'ldap:///ipauniqueid=*,cn=hbac,dc=idm,dc=lab,dc=eng,dc=brq,dc=redhat,dc=com',
'attrs': [u'servicecategory', u'sourcehostcategory', u'cn',
u'description', u'ipaenabledflag', u'accesstime', u'usercategory',
u'hostcategory', u'accessruletype', u'sourcehost'],
'memberindirect_role': [u'IT Security Specialist'], 'permissions':
[u'write']}
got = {'dn': u'cn=Modify SELinux User
Maps,cn=permissions,cn=pbac,dc=idm,dc=lab,dc=eng,dc=brq,dc=redhat,dc=com',
'cn': (u'Modify SELinux User Maps',), 'member_privilege': (u'SELinux
User Map Administrators',), 'subtree':
u'ldap:///ipauniqueid=*,cn=usermap,cn=selinux,dc=idm,dc=lab,dc=eng,dc=brq,dc=redhat,dc=com',
'attrs': (u'cn', u'memberuser', u'memberhost', u'seealso',
u'ipaselinuxuser', u'ipaenabledflag'), 'permissions': (u'write',)}
path = ('result', 0)
----------------------------------------------------------------------
Ran 64 tests in 19.128s
FAILED (failures=1)
======================================================================
FAILED under '/usr/bin/python2.7'
Can you reproduce this?
I can look into it when I have time.
--
Petr³
_______________________________________________
Freeipa-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/freeipa-devel
