On 12/10/2013 02:10 PM, Jan Cholasta wrote:
the attached patches fix <https://fedorahosted.org/freeipa/ticket/3488>.
These look great, thanks! Just a couple of questions/nicpicks.
Does the new method guarantee 'attributetypes' are updated before
I can move the logic to schemaupdate if needed.
Why is OnlyOneValueAllowed not raised any more? It should be, since the
method assumes get_single_value() gives correct information.
Why is MOD_REPLACE no longer used when no old values are retained? Or
(MOD_DELETE, a, None) when the new set is empty?
An ancient comment in ldapupdate still has a reference to orig_data in,
can you remove the comment as well?
I noticed that IPASimpleLdapObject.convert_result's docstring is
obsolete, could you update/shorten it?
Freeipa-devel mailing list