On 01/15/2014 11:06 PM, Rob Crittenden wrote:
> Simo Sorce wrote:
>> On Wed, 2014-01-15 at 15:31 -0500, Rob Crittenden wrote:
>>> Simo Sorce wrote:
>>>> Uniform fallback for global_policy and stop explicitly adding the
>>>> default policy to all user accounts.
>>>>
>>>> Tested.
>>>>
>>>> Simo.
>>>
>>> ACK but you need this change in order for the unit tests to pass:
>>>
>>> diff --git a/ipatests/test_xmlrpc/test_user_plugin.py
>>> b/ipatests/test_xmlrpc/
>>> test_user_plugin.py
>>> index 14a4b50..9b17775 100644
>>> --- a/ipatests/test_xmlrpc/test_user_plugin.py
>>> +++ b/ipatests/test_xmlrpc/test_user_plugin.py
>>> @@ -99,10 +99,6 @@ def get_user_result(uid, givenname, sn, operation='sh
>>> ow', omit=[],
>>>                mepmanagedentry=[get_group_dn(uid)],
>>>                objectclass=add_oc(objectclasses.user, u'ipantuserattrs'),
>>>                krbprincipalname=[u'%s@%s' % (uid, api.env.realm)],
>>> -            krbpwdpolicyreference=[DN(('cn', 'global_policy'),
>>> -                                      ('cn', api.env.realm),
>>> -                                      ('cn', 'kerberos'),
>>> -                                      api.env.basedn)],
>>>            )
>>>        if operation in ('show', 'show-all', 'find', 'mod'):
>>>            result.update(
>>>
>>
>> Attached  both patches again, the first is the same as before, the
>> second is updated with the above snippet.
>>
>> Thanks for the review.
>>
>> Simo.
>>
> 
> ACK

Pushed to master, ipa-3-3 (I just had to rebase the ipatests update patch as
tested user entry was not consolidated and krbpwdpolicyreference was defined in
about 20 places).

Martin

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to