On 01/27/2014 12:17 PM, Timo Aaltonen wrote: > On 28.11.2013 22:26, Lukas Slebodnik wrote: >> On (05/09/13 23:25), Lukas Slebodnik wrote: >>> On (03/09/13 00:43), Timo Aaltonen wrote: >>>> >>>> This fixes https://fedorahosted.org/freeipa/ticket/1887 >>>> and >>>> https://fedorahosted.org/freeipa/ticket/2455 >>>> >>>> the first three patches fix some bugs in how python is used >>>> fourth patch checks if dbus is already running before trying to start it >>>> fifth fixes some compilation warnings >>>> sixth finally adds the Debian platform module >>>> >>>> >>>> >>>> there are also distro patches that aren't upstreamable as-is, that do >>>> stuff like >>>> - give--install-layout=deb to setup.py >>>> - disable make-testcert since it needs a server running >>>> - fix hardcoded NFS related paths and a variable in ipa-client-automount >>>> - fix ldap.conf path in ipa-client-install >>>> - fix ntpdate options in ntpconf.py (Debian doesn't patch ntpdate like >>>> Fedora) >>>> - change nss includes in ipa_pwd.c (<nss/..> not <nss3/..>) >>> Solution is simple. Use pkg-config generated NSS_CFLAGS >>> >>> bash$ pkg-config --cflags nss >>> -I/usr/include/nss -I/usr/include/nspr >>> bash$ uname -a >>> Linux positron 3.10-2-686-pae #1 SMP Debian 3.10.5-1 (2013-08-07) i686 >>> GNU/Linux >>> >>> bash$pkg-config --cflags nss >>> -I/usr/include/nss3 -I/usr/include/nspr4 >>> bash$uname -a >>> Linux unused-4-233.brq.redhat.com 3.10.10-200.fc19.x86_64 #1 SMP Thu Aug 29 >>> 19:05:45 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux >>> >>> It works in sssd. I can send a patch. >>> >>> LS >>> >> Attached patch should fix problem with compilation on different distros. >> >> debian: >> http://anonscm.debian.org/gitweb/?p=pkg-freeipa/freeipa.git;a=blob;f=debian/patches/fix-nss-include.diff;h=1dac0709ed7344c7546c55225365c9434e6a930a;hb=HEAD >> arch: >> https://github.com/chenxiaolong/ArchLinux-Packages/blob/master/freeipa/0006_Fix_nss_includes.patch >> >> Timo can you test patch on debian/ubuntu? > > finally did last week, so > > Tested-by: Timo Aaltonen <[email protected]>
Thanks Timo. I did a mild rebase to current master, tested FreeIPA in Fedora still builds and pushed to master. Martin _______________________________________________ Freeipa-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/freeipa-devel
