On 02/05/2014 01:06 PM, Tomas Babej wrote:

On 02/05/2014 12:47 PM, Petr Viktorin wrote:
On 02/05/2014 11:23 AM, Petr Viktorin wrote:
On 02/05/2014 10:29 AM, Tomas Babej wrote:

the attached patches fix the following tickets:


Details in the commit messages.


These look good, just a few nitpicks:

Use a lowercase "A" in option and method names in 0144 to keep
consistent with our naming convention.

Add an article to the add_a_record docstring & man page:
Adds an A record for the host to the IPA master

and the help text for the host argument could be better:
Host whose record should be added
(or, Host for which the record should be added)

Another issue, in 0145 the copyfiles_command should be run with
raiseonerr=False, so we don't fail in cease the directory doesn't exist.

Thank you for the review, updated patches attached.

Thank you! ACK, pushed to
master: 1601860023193ec295458a71f1f097edbb57d787
ipa-3-3: 57e6b5bdc540551312fd674c56ded7dbb7322677


Freeipa-devel mailing list

Reply via email to