On 02/25/2014 04:01 PM, Petr Viktorin wrote:
On 02/25/2014 02:47 PM, Jan Cholasta wrote:
On 21.2.2014 12:11, Adam Misnyovszki wrote:



----- Original Message -----
From: "Jan Cholasta" <jchol...@redhat.com>
To: "Adam Misnyovszki" <amisn...@redhat.com>, freeipa-devel@redhat.com
Sent: Friday, February 21, 2014 11:05:12 AM
Subject: Re: [Freeipa-devel] [PATCH] Certificate search
max_serial_number problem fixed

Hi,

On 20.2.2014 18:15, Adam Misnyovszki wrote:
Hi,

this patch fixes ticket https://fedorahosted.org/freeipa/ticket/4163
maximum serial number field now accepts only positive numbers

Thanks
Adam

I think you should also add maxvalue to min_serial_number, so that they
are consistent.

Honza

--
Jan Cholasta


Makes sense, new patch added.

Adam


Thanks, ACK.


Pushed to master: be7b1b94e300b137c34bab80df3dc91195259c89


Adam, you have not updated API.txt. To do this you need to run the makeapi script when changing the API. When you run `make rpms` you will be warned if there is a mismatch. FWIW, I have the following in my .git/hooks/post-commit, so Git alerts me of problems after a commit:

    ./makeapi
git status --short # Show modified files, mainly for the case that makeapi modified API.txt



Honza, please make sure IPA actually builds before you ACK a patch.


Attached fix pushed as one-(well,two)-liner to master: 00d6b529c977c19fc5bb2e230da551ac01c79d79

--
PetrĀ³

From 562617f7a845fe468510ff27688039794ce0dd80 Mon Sep 17 00:00:00 2001
From: Petr Viktorin <pvikt...@redhat.com>
Date: Tue, 25 Feb 2014 16:20:04 +0100
Subject: [PATCH] Update API.txt

This fixes commit be7b1b94e300b137c34bab80df3dc91195259c89
https://fedorahosted.org/freeipa/ticket/4163
---
 API.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/API.txt b/API.txt
index 504a60ff31686cfa828c3a8f17debd6dad3bb60d..070134959dd2cfdd7a281b3e50d8bc92fe21cdeb 100644
--- a/API.txt
+++ b/API.txt
@@ -453,8 +453,8 @@ command: cert_find
 option: Flag('exactly?', autofill=True, default=False)
 option: Str('issuedon_from?', autofill=False)
 option: Str('issuedon_to?', autofill=False)
-option: Int('max_serial_number?', autofill=False, maxvalue=2147483647)
-option: Int('min_serial_number?', autofill=False, minvalue=0)
+option: Int('max_serial_number?', autofill=False, maxvalue=2147483647, minvalue=0)
+option: Int('min_serial_number?', autofill=False, maxvalue=2147483647, minvalue=0)
 option: Flag('raw', autofill=True, cli_name='raw', default=False, exclude='webui')
 option: Int('revocation_reason?', autofill=False, maxvalue=10, minvalue=0)
 option: Str('revokedon_from?', autofill=False)
-- 
1.8.5.3

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to