This is a minor fix. Please don't close ticket 3904 yet if committed.
Checkboxes have not used unique ids across the whole UI. It broke checking by clicking on label for later displayed instances. It became serious problem when rcue introduced new checkbox styles with 'label clicking' as default check method.
https://fedorahosted.org/freeipa/ticket/3904 -- Petr Vobornik
From e64cbab0e4a3ef427e4f74e6f1183a9231dfb6c5 Mon Sep 17 00:00:00 2001 From: Petr Vobornik <pvobo...@redhat.com> Date: Thu, 16 Jan 2014 13:54:03 +0100 Subject: [PATCH] webui: use unique ids for checkboxes Checkboxes have not used unique ids across the whole UI. It broke checking by clicking on label for later displayed instances. It became serious problem when rcue introduced new checkbox styles with 'label clicking' as default check method. https://fedorahosted.org/freeipa/ticket/3904 --- install/ui/src/freeipa/widget.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/install/ui/src/freeipa/widget.js b/install/ui/src/freeipa/widget.js index 81db75e5776bd37964efdb1b4feb38ba4355204f..6ee61c6583509301d0aa98f64fefa14d5d27f5ea 100644 --- a/install/ui/src/freeipa/widget.js +++ b/install/ui/src/freeipa/widget.js @@ -1201,10 +1201,7 @@ IPA.option_widget_base = function(spec, that) { that.get_input_name = function() { if (!that._input_name) { - var name = that.name; - if (that.input_type === 'radio') { - name = IPA.html_util.get_next_id(name); - } + var name = IPA.html_util.get_next_id(that.name); that._input_name = name; that._selector = 'input[name="'+name+'"]'; } -- 1.8.5.3
_______________________________________________ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
