On 03/04/2014 04:59 PM, Tomas Babej wrote:
Thanks,

PATCH 341: ACK

(this is the last remaining ACK for this patchset)

Thank you!
Pushed to master: 561e57d12169cfa4e1d2c5d9fef42b149c37fca2

On 03/04/2014 11:58 AM, Petr Viktorin wrote:
On 03/03/2014 01:41 PM, Tomas Babej wrote:
Finally got to this patchset!

PATCH 337: ACK
PATCH 338: ACK

This prohibits us to use extra roles that end in digits. Can you put a
note explaining that in

http://www.freeipa.org/page/V3/Integration_testing#Host_configuration

Updated.

Also, this wiki page points out to environment variables so that it
seems it is the preferred method of configuration. We should mention
more user friendly YAML here first.

Let's do that when the patches are pushed. #3938 should stay open
until it's done.

PATCH 339: ACK
PATCH 340: ACK
PATCH 341:

The have_master variable seems redundant in from_dict method (it's only
a local definition and not referenced anywhere else):

+    def from_dict(cls, dct, config):
+        from ipatests.test_integration.host import BaseHost
+
+        domain_type = dct.pop('type')
+        assert domain_type in ('IPA', 'AD')
+        domain_name = dct.pop('name')
+        self = cls(config, domain_name, domain_type)
+
+        have_master = False
+        for host_dict in dct.pop('hosts'):
+            host = BaseHost.from_dict(host_dict, self)
+            self.hosts.append(host)
+            if host.role == 'master':
+                have_master = True
+
+        check_config_dict_empty(dct, 'domain %s' % domain_name)
+
+        return self

Right you are. Fixed.

PATCH 342: ACK
PATCH 343: ACK

PATCH 348: ACK
PATCH 349: ACK






--
PetrĀ³

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to