On 03/19/2014 01:43 PM, Martin Basti wrote:
On Tue, 2014-03-18 at 14:34 +0100, Petr Viktorin wrote:
On 09/26/2013 06:52 PM, Martin Basti wrote:
Patch for chapter 5

Contains patch for ticket

Thanks for the patches!

Next time, when you do multiple changes, please split them into multiple
patches. Each of the bullet points in the commit message could have been
a separate patch.
However splitting the patch now is probably not worth the effort.

I did however split the whitespace fixes to make my job easier. I also
rebased a minor conflict. Attaching the patches for convenience.

In section 5.1.3 the examples are missing the [user@ipaserver ~] prompt.

In section there's an extra `$` prompt that's not present in
other syntax examples.
Removed extra '$'.

Section should not be an ordered list since it presents two
ways to do the same thing.
Moved to unnumbered list.

In Table 5.3, instead of removing posixgroup altogether you should
mention that it's only added for POSIX groups.
Added footnote.

Otherwise the changes look good.

Thank you for review.
Updated patch attached.

ACK, pushed to master: 50f0658ec634adf91e4794f8bcbb79e318472835


Freeipa-devel mailing list

Reply via email to