On 25.3.2014 16:07, Petr Viktorin wrote:
On 03/25/2014 03:05 PM, Jan Cholasta wrote:
On 21.3.2014 09:46, Petr Viktorin wrote:
On 03/19/2014 02:33 PM, Jan Cholasta wrote:
[...]


Updated patches attached.

Note that I changed the path for CSR export to /var/lib/ipa/ca.csr to
make it more SELinux-friendly (not in the policy yet, see
<https://bugzilla.redhat.com/show_bug.cgi?id=1077689>).


Updated patches attached.

Note I have also updated the CA master in LDAP code.


Looks better!
In patch 190, AFAICS the original CAInstance.is_master is now not used
anywhere, and its uses were always renewal-related. Is it safe to remove
it?

Yes.

--
Jan Cholasta
>From 9b5100c64862b242522d78237e58d7a24485f993 Mon Sep 17 00:00:00 2001
From: Jan Cholasta <jchol...@redhat.com>
Date: Tue, 25 Mar 2014 16:10:55 +0100
Subject: [PATCH] Remove unused method is_master of CAInstance.

---
 ipaserver/install/cainstance.py | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/ipaserver/install/cainstance.py b/ipaserver/install/cainstance.py
index 0b93b72..f528704 100644
--- a/ipaserver/install/cainstance.py
+++ b/ipaserver/install/cainstance.py
@@ -1543,21 +1543,6 @@ class CAInstance(service.Service):
             return True
         return False
 
-    def is_master(self):
-        """
-        There are some tasks that are only done on a single dogtag master.
-        By default this is the first one installed. Use this to determine if
-        that is the case.
-
-        If users have changed their topology so the initial master is either
-        gone or no longer performing certain duties then it is their
-        responsibility to handle changes on upgrades.
-        """
-        master = installutils.get_directive(
-            self.dogtag_constants.CS_CFG_PATH, 'subsystem.select', '=')
-
-        return master == 'New'
-
     def is_renewal_master(self):
         if not self.admin_conn:
             self.ldap_connect()
-- 
1.8.5.3

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to