On 25.3.2014 16:26, Misnyovszki Adam wrote:
On Tue, 25 Mar 2014 12:49:24 +0100
Petr Vobornik <pvobo...@redhat.com> wrote:

On 20.3.2014 16:51, Misnyovszki Adam wrote:
On Wed, 19 Mar 2014 16:02:12 +0100
Petr Vobornik <pvobo...@redhat.com> wrote:

- unites domNode and dom_node usage to dom_node

Nack,

install/ui/test/details_tests.js:236
install/ui/test/details_tests.js:242

only finds element, because context(ie domNode) is undefined, so it
falls back to html, not the best idea

install/ui/src/freeipa/widgets/App.js:55

not sure if this causes errors, but it's worth renaming for
consistency

Greets,
Adam


all fixed, patch attached.

ACK

Pushed to master: 7fc8d241b2df352adbc51616ae3eb5dc4199a75e
--
Petr Vobornik

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to