On 04/17/2014 04:31 PM, Petr Viktorin wrote:
On 04/17/2014 12:22 PM, Tomas Babej wrote:
On 04/09/2014 01:33 PM, Petr Viktorin wrote:
On 04/09/2014 12:07 PM, Tomas Babej wrote:
Hi,

the following batch deals with the following:

* cleans up apache's semaphores prior to installing IPA (CA install can
get stuck when IPA is reinstalled many times)

What happens if Apache is running for some reason? Should we also stop
it before deleting the semaphores?

Agreed, if for any reason apache is running, we should stop it
beforehand. Fixed.


* allows to pass extra arguments to install_client task

Please avoid mutable argument defaults; use `extra_args=()` and then
`list(extra_args)`

Fixed.


* uses trailing dot in the hostname as fqdn which should not be
overridden by domain name

ACK.

* fixes incorrect assert for UIDs/GIDs in legacy client tests

ACK, this fixes a lot of failures (though not all of them yet).


Updated patches attached.


ACK, pushed to:
master: f74ab3cba2b02e4726519e602f7de4fc86fca2d1
ipa-3-3: be8f4768877168720d051ba94c3e908af67f1306

There are some test failures in ipatests/test_integration/test_testconfig.py that I missed. This patch fixes them. Does it look good to you?


--
PetrĀ³
From 7cf9e3f825b8b98fa30d97201b07243240c70d0f Mon Sep 17 00:00:00 2001
From: Petr Viktorin <pvikt...@redhat.com>
Date: Fri, 18 Apr 2014 12:48:49 +0200
Subject: [PATCH] test_integration.host: Export the hostname to dict as string

Our tests do strict type-checking, using unicode string causes failures.
---
 ipatests/test_integration/host.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ipatests/test_integration/host.py b/ipatests/test_integration/host.py
index 94440c1875654a6866e25f173b27b9fedd5d5945..7a3a6ac77565cedddc416713d53ee5647c6f3e61 100644
--- a/ipatests/test_integration/host.py
+++ b/ipatests/test_integration/host.py
@@ -142,7 +142,7 @@ def from_dict(cls, dct, domain):
 
     def to_dict(self):
         return {
-            'name': self.hostname,
+            'name': str(self.hostname),
             'ip': self.ip,
             'role': self.role,
             'external_hostname': self.external_hostname,
-- 
1.9.0

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to