On Wed, 23 Apr 2014 16:57:35 +0200
Petr Vobornik <pvobo...@redhat.com> wrote:
> On 18.4.2014 10:43, Misnyovszki Adam wrote:
> > Hi,
> > this patch fixes select_all checkbox issue, after any bulk modify or
> > delete operation, the checkbox is deselected.
> > https://fedorahosted.org/freeipa/ticket/4245
> >
> > Thanks
> > Adam
> >
>
> The issue still exists in association facets and also maybe in
> attribute facet (group/external) (not tested).
Hi,
thanks for the review, see the attached corrections!
Adam
>From 53e406c33d51a3af3c83cab079ab81374d05a91e Mon Sep 17 00:00:00 2001
From: Adam Misnyovszki <amisn...@redhat.com>
Date: Wed, 23 Apr 2014 17:41:45 +0200
Subject: [PATCH] webui: select all checkbox remains selected after operation
The select all checkbox remained selected after bulk
operation. This patch fixes it, after any bulk modify
or delete operation, unselect_all function is called.
https://fedorahosted.org/freeipa/ticket/4245
---
install/ui/src/freeipa/association.js | 2 ++
install/ui/src/freeipa/dialog.js | 6 +++++-
install/ui/src/freeipa/search.js | 2 ++
3 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/install/ui/src/freeipa/association.js b/install/ui/src/freeipa/association.js
index bf11de0051bdd88fa5bfb58122a5ede95e10bab2..aee95f184cd2543f56bfc63a508be797628e76d6 100644
--- a/install/ui/src/freeipa/association.js
+++ b/install/ui/src/freeipa/association.js
@@ -1203,6 +1203,7 @@ exp.association_facet = IPA.association_facet = function (spec, no_init) {
method: that.remove_method,
on_success: function(data) {
that.refresh();
+ that.table.unselect_all();
var succeeded = IPA.get_succeeded(data);
var msg = text.get('@i18n:association.removed').replace('${count}', succeeded);
@@ -1473,6 +1474,7 @@ exp.attribute_facet = IPA.attribute_facet = function(spec, no_init) {
function(data) {
that.load(data);
that.show_content();
+ that.table.unselect_all();
var succeeded = IPA.get_succeeded(data);
var msg = text.get('@i18n:association.removed').replace('${count}', succeeded);
diff --git a/install/ui/src/freeipa/dialog.js b/install/ui/src/freeipa/dialog.js
index 4c6c37f88e628aaf93f353d245bd2763db830529..6fdfbc62da48cf6fbb31a9a467bb989cbf78ec18 100644
--- a/install/ui/src/freeipa/dialog.js
+++ b/install/ui/src/freeipa/dialog.js
@@ -885,6 +885,8 @@ IPA.adder_dialog = function(spec) {
that.add = function() {
var rows = that.available_table.remove_selected_rows();
that.selected_table.add_rows(rows);
+ that.available_table.unselect_all();
+ that.selected_table.unselect_all();
};
/**
@@ -893,6 +895,8 @@ IPA.adder_dialog = function(spec) {
that.remove = function() {
var rows = that.selected_table.remove_selected_rows();
that.available_table.add_rows(rows);
+ that.available_table.unselect_all();
+ that.selected_table.unselect_all();
};
/**
@@ -1357,4 +1361,4 @@ dialog_builder.factory = IPA.dialog;
reg.set('dialog', dialog_builder.registry);
return {};
-});
\ No newline at end of file
+});
diff --git a/install/ui/src/freeipa/search.js b/install/ui/src/freeipa/search.js
index 9400b6aec133935fc7c3ed21c695fe3c6bc7b7de..8701c33c3b3752cdeddffebe3cb325d26ad81dee 100644
--- a/install/ui/src/freeipa/search.js
+++ b/install/ui/src/freeipa/search.js
@@ -353,6 +353,7 @@ IPA.search_deleter_dialog = function(spec) {
batch.on_success = function(data, text_status, xhr) {
that.facet.refresh();
that.facet.on_update.notify([],that.facet);
+ that.facet.table.unselect_all();
var succeeded = batch.commands.length - batch.errors.errors.length;
var msg = text.get('@i18n:search.deleted').replace('${count}', succeeded);
IPA.notify_success(msg);
@@ -505,6 +506,7 @@ IPA.batch_items_action = function(spec) {
that.on_success = function(facet, data, text_status, xhr) {
facet.on_update.notify();
facet.refresh();
+ facet.table.unselect_all();
if (that.success_msg) {
var succeeded = that.batch.commands.length - that.batch.errors.errors.length;
--
1.9.0
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
