Hi, see my review notes below: On Mon, 05 May 2014 18:41:13 +0200 Petr Vobornik <pvobo...@redhat.com> wrote:
> This patchset updates Bootstrap 2 based RCUE to Bootstrap 3 based > PatternFly (v0.2.4) according to plan described at: > > http://www.redhat.com/archives/freeipa-devel/2014-April/msg00045.html > > The rest of the patches are mostly response to new CSS styles + some > new functionality and simplification of UI: > - css cleanup, images cleanup > - adjustment of stand-alone pages to PF > - adjustment of DOM structure to Bootstap 3 structure > - BS 3 enabled to change absolute positioned layout to responsive > fluid layout > - new activity indicators (since the old didn't fit into PF > navigation) > - new pager styles + additional behavior > - action select transform into dropdown and moved to control-button > section, making the header responsive > - fluid layout requested removal of computation of columns widths > - removal of login.html and logout.html > - new login background (the old one did not work with PF styles) > - new dialog styles > - + additional adjustments to use PF > > The result is that UI uses most of PatternFly styles and is > responsive. > > Fixes: > https://fedorahosted.org/freeipa/ticket/4177 - Better indication of > ongoing activity if dialog is opened - working progress could have a border. if it is over a dialog, sometimes it looks messy over text > https://fedorahosted.org/freeipa/ticket/4136 - WebUI unusable on > Cellphone screen - when I open the menu in 320x480, and select and navigate to an item, the menu stays open - needs more investigation, if it is freeipa ui issue - qr code is fixed size in otp tokens, doesn't look nice on small screens not a problem, user just clicks on qr code link - when a table header is longer, than the actual screen size, overflow hidden occurs, unable to use buttons at the end of the header eg DNS Resource Records, 320x480px, sometimes delete and add button overflows the table, you can only scroll that table with tap not a problem, responsive table works this way - in 320x480, login page configuration text overflows on a white background, especially if there is a login error, which makes the white text unreadable > https://fedorahosted.org/freeipa/ticket/4255 - Web UI: Display > "Loading" message when a list of entries is being loaded see working progress comment above > https://fedorahosted.org/freeipa/ticket/3435 - [RFE] Remove width > limit in UI ACK - PatternFly 3 handles this very neatly > https://fedorahosted.org/freeipa/ticket/3050 - WebUI: it is not clear > which row a value belongs to ACK - row color alternation hopefully solves the problem > https://fedorahosted.org/freeipa/ticket/4278 - Use Patternfly theme > in config and migration pages FreeIPA logo doesn't lead anywhere, no way to navigate to the login page, only by altering the url, or clicking the back button. IMO logo should always lead to login page if not logged in. > https://fedorahosted.org/freeipa/ticket/4281 - Remove login.html and > logout.html ACK > https://fedorahosted.org/freeipa/ticket/4282 Other issues: - unit tests have several fails, possibly because of dom changes - integration tests ran without errors Also, according to the UX meeting with Kyle, this patchset should include the following changes: - placeholder for search, box should be on the left - actions in one place, on the right in search page - actions in one place, on the left in details page - action dropdown list to the right near update button in details page - left align form fields in details page, two columns arrangement if the screen is wide - hbac details pages - leave it as it is, no form modification required - association adder dialog - placeholder for textbox(Filter available), change button text "Filter" - search page title should be changed - use dark variant text - multi value list - "add" to button, with "undo all" button group - multi value list - "delete" should be also a button - left align firefox configuration page steps - ie. every static page - migration should look like login, (~reset_password), text should go to right - error page "return back" should be a button Thanks Adam _______________________________________________ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
