On 06/06/2014 08:36 AM, Gabe Alford wrote:
Hello,
Patch 21:
This is a patch for https://fedorahosted.org/freeipa/ticket/3724
Nope, doesn't work for me: nolog_replace expects a string.
File
"/usr/lib/python2.7/site-packages/ipaserver/install/installutils.py",
line 639, in run_script
return_value = main_function()
File "/usr/sbin/ipa-upgradeconfig", line 1140, in main
certificate_renewal_update(ca),
File "/usr/sbin/ipa-upgradeconfig", line 691, in
certificate_renewal_update
ca.configure_renewal()
File
"/usr/lib/python2.7/site-packages/ipaserver/install/cainstance.py", line
1444, in configure_renewal
post_command='renew_ca_cert "%s"' % nickname)
File "/usr/lib/python2.7/site-packages/ipapython/certmonger.py", line
431, in dogtag_start_tracking
(stdout, stderr, returncode) = ipautil.run(args, nolog=[pin])
File "/usr/lib/python2.7/site-packages/ipapython/ipautil.py", line
305, in run
arg_string = nolog_replace(args, nolog)
File "/usr/lib/python2.7/site-packages/ipapython/ipautil.py", line
360, in nolog_replace
string = string.replace(nolog_value, 'XXXXXXXX')
I'd recommend something like ' '.join(shell_quote(a) for a in args).
Patch 22:
This is part of https://fedorahosted.org/freeipa/ticket/4316 and adds
the API to 'ipa env'
One question that I had for adding 'ipa --version' is if using the
default optparse version argument would be sufficient/intended i.e.
version=('Version: %s, API_Version: %s' % (version, api_version) or if a
custom optparse argument is needed.
I think the default will be just fine. Can you update the patch to add
the option?
--
Petr³
_______________________________________________
Freeipa-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/freeipa-devel
