On 06/25/2014 05:03 PM, Martin Basti wrote:
On Wed, 2014-06-25 at 15:54 +0200, Petr Viktorin wrote:
On 06/20/2014 03:28 PM, Martin Basti wrote:
Patch attached.

Ticket:https://fedorahosted.org/freeipa/ticket/4383

This works, just two comments:

To check if an entry exists, instead of calling
      api.Command['permission_show'](permission_name_rel)
you should call the more light-weight
      api.Object[permission].get_dn_if_exists(permission_name_rel)

And for translated messages, use:
      _('message about %(topic)s") % {...}
rather than:
      _('message about %(topic)s" % {...})
In other words, _() must be called on a literal string. Otherwise it
couldn't be looked up in the translation database (or even picked up by
gettext).


Thank you for review.
Updated patch attached.


Thanks!
ACK, pushed to master: 816007bdd911065b42170a06aea3cf750a5198fe

--
PetrĀ³

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to