On 6/27/2014 3:54 AM, Petr Vobornik wrote:
On 27.6.2014 09:48, Fraser Tweedale wrote:
On Wed, Jun 25, 2014 at 06:58:52PM +0200, Petr Vobornik wrote:
Patch 618 fixes a bug.
Patches 680 and 681 were implemented along with it. They address
usability rant :).
[PATCH] 680 webui: show notification instead of modal dialog on
[PATCH] 681 webui: fix required error notification in multivalued widget
[PATCH] 682 webui: focus invalid widget on validation error
ACK on 680 and 682.
On 681: diff makes sense; I'm not 100% sure my testing has covered
cases that were previously failing. ACK if you're confident,
otherwise could you provide steps to verify?
You need to find a required multivalued field. One is in "Identity/Realm
Domains". Delete all values and hit update. It's little bit related to
Also when verifying validators in multivalued field, it's good to check
if errors are provided only for "invalid" values, etc.. good test field
is in "DNS/DNS Zones/some zone/Settings/ there is "Allow query" field
which accepts network address, "any" or "none".
This should be sufficient to close #4057. But just wondering, the Realm
Domains page right now is implemented as a details page with a
multi-valued widget. Would it make more sense to be a list page instead?
The realmdomains-mod CLI is kind of unusual too with the
--add/del-domain parameters. Why not use realmdomain-add/del commands?
Are there other commands implemented in this fashion?
Endi S. Dewata
Freeipa-devel mailing list