On 07/01/2014 10:43 AM, Petr Spacek wrote:
On 30.6.2014 17:10, Martin Basti wrote:
On Mon, 2014-06-30 at 16:57 +0200, Petr Spacek wrote:
On 30.6.2014 14:33, Martin Basti wrote:
On Mon, 2014-06-30 at 12:49 +0200, Martin Basti wrote:
Patch attached.

It works for me.

Please change the string little bit, I have realized that we should
that file permissions are correct:

chown named: *
chmod u= *

(the chmod part new)


Updated patch attached

I'm really sorry, I had to change the message once again :-)

None of us noticed that chmod command was completely incorrect. I'm
attaching fixed patch as an apology.

It works for me when applied to master

Functional self-ACK :-)

IMHO it can be pushed if Python-review is okay.

Once again, please define new message classes in messages.py instead of just using PublicMessage with a custom string.

Also, these messages will work for console output, but I'm not sure pre-wrapped text would look good in web UI. I'm not sold on the idea of giving instructions in warning messages. Would a link to some documentation be better?


Freeipa-devel mailing list

Reply via email to