On 07/01/2014 12:10 PM, Martin Basti wrote:
On Mon, 2014-06-30 at 13:57 +0200, Petr Viktorin wrote:
On 06/30/2014 12:48 PM, Martin Basti wrote:
Ticket: https://fedorahosted.org/freeipa/ticket/3210#comment:16
Patch attached.


When you add a new message, you should also define a new class for it in
messages.py with a new errno, not just reuse PublicMessage with a custom
string.



Could it be WarningMessage? Or should I be more specific
ForwardersWarningMessage, DNSSECWarningMessage ?

Be specific. I'd go for DNSSECWarning; "message" is already in the module name.

Is there any rule how to choose errno?

Just use the next unused one.


--
PetrĀ³

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to