On 09/01/2014 01:15 PM, Jakub Hrozek wrote:
On Mon, Sep 01, 2014 at 11:01:23AM +0200, Martin Kosek wrote:
On 08/25/2014 07:36 PM, Jakub Hrozek wrote:
Hi,

ipa-client-install was failing for me on a fresh F-21 machine until I
manually dragged in python-backports-ssl_match_hostname

Umh, thanks for the fix, but I do not think this spec is actually used in our
build process. The last update was done in 2008 :-)

We only use the global freeipa.spec.in and build client from that. I think we
should just delete the old one.

Martin

OK, I promise to test my patches next time :-)

rpm -q --requires shows the python-backports-ssl_match_hostname
dependency now.

What about the one in attachment? If it doesn't work for you, feel free
to just take over the patch..

This also needs to be in BuildRequires to pass pylint. Patch attached.

--
PetrĀ³

From 2b81ee74449aab55c2611b8fa45b208559729d1b Mon Sep 17 00:00:00 2001
From: Jakub Hrozek <jhro...@redhat.com>
Date: Mon, 1 Sep 2014 13:01:41 +0200
Subject: [PATCH] freeipa.spec.in: Explicitly require
 python-backports-ssl_match_hostname

Without python-backports-ssl_match_hostname installed, an ipa-client
installation could have failed with:
    from backports.ssl_match_hostname import match_hostname
    ImportError: No module named ssl_match_hostname
Also, the build-time lint would fail.

This patch adds an explicit dependency to
python-backports-ssl_match_hostname.
---
 freeipa.spec.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/freeipa.spec.in b/freeipa.spec.in
index 6df4f06f2925700a35a4fc608c379ac400caa888..b872ea0c4db1e3f853f3d72e4d63b86e8d585702 100644
--- a/freeipa.spec.in
+++ b/freeipa.spec.in
@@ -72,6 +72,7 @@ BuildRequires:  systemd
 BuildRequires:  libunistring-devel
 BuildRequires:  python-lesscpy
 BuildRequires:  python-yubico
+BuildRequires:  python-backports-ssl_match_hostname
 
 %description
 IPA is an integrated solution to provide centrally managed Identity (machine,
@@ -203,6 +204,7 @@ Requires: libsss_autofs
 Requires: autofs
 Requires: libnfsidmap
 Requires: nfs-utils
+Requires: python-backports-ssl_match_hostname
 Requires(post): policycoreutils
 
 Obsoletes: ipa-client >= 1.0
-- 
1.9.3

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to