On 2.9.2014 17:22, Nathaniel McCallum wrote:
On Tue, 2014-09-02 at 13:49 +0200, Petr Vobornik wrote:
On 28.8.2014 20:14, Nathaniel McCallum wrote:
On Tue, 2014-08-19 at 16:46 -0400, Nathaniel McCallum wrote:
Also, remove the attempt to load the objectClasses when absent. This
never makes sense during an add operation.

https://fedorahosted.org/freeipa/ticket/4455

I still need a review for this. We are trying to get this in 4.0.2.

Nathaniel


ACK if comment below doesn't need any change:

Maybe I'm missing something, but why do we do following check: `if
'objectclass' in entry_attrs:`? Shouldn't it be always True? Since
the objectclass is set in LDAPCreate.execute. A pre-callback in an third
party plugin can remove it, but I don't think we should care.

I also thought that was odd, but I cargo-culted it to retain backwards
compatibility. Attached is a version of the patch which doesn't retain
this. I don't care which gets merged.

Nathaniel


ACK

Pushed to:
master: e26b3e14eb07baa4868109307d9d064bab4c5e0b
ipa-4-1: 480512f6db4d4b487e3376e7bca1b658d76c6f86
ipa-4-0: 4200af9b7a8c254b02034b067b29a3e66532daa2
--
Petr Vobornik

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to