On 09/03/2014 03:53 PM, Tomas Babej wrote:
Hi,

Makes sure that any new sources added are not already present
in the entry.

https://fedorahosted.org/freeipa/ticket/4508

It works fine, ACK.

I do have some comments, but 4.0.x is a stabilization release, so they'd probably be better in a 4.1 patch:

The way you first join default_value to make configured_services, and
then repeatedly split it, looks quite wasteful. Wouldn't configured_services be better as a list? Also I wonder if configure_nsswitch_database needs those unused preserve/append options.

Should I push now?

--
PetrĀ³

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to