On 09/24/2014 04:07 PM, Martin Basti wrote:
> On 23/09/14 18:53, Martin Basti wrote:
>> On 23/09/14 18:35, Petr Spacek wrote:
>>> On 22.9.2014 19:21, Martin Basti wrote:
>>>> On 22/09/14 13:17, Petr Vobornik wrote:
>>>>> On 19.9.2014 16:15, Martin Basti wrote:
>>>>>> Ticket: https://fedorahosted.org/freeipa/ticket/3414
>>>>>> Patch attached.
>>>>>>
>>>>>
>>>>> Patch 126:
>>>>>
>>>>> 1. I think that just
>>>>>   DeprecatedParam('dnsclass?'),
>>>>>
>>>>> should be enough.
>>>>>
>>>>> Also
>>>>>
>>>>> 2. You forgot to update API.txt and VERSION
>>>>>
>>>>> Patch 127:
>>>>>  ACK
>>>>>
>>>> Updated patchset attached
>>>
>>> ACK, it works for me.
>>>
>> Please don't push, we discuss this and we will nit use the DeprecatedParam.
>>
> Updated patch attached

Just a nitpick - I think these 2 patches would also be squashed - I did not see
a point in dividing the changes there... Not a blocker, just sayin'.

Martin

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to