On 24/09/14 16:07, Martin Basti wrote:
On 23/09/14 18:53, Martin Basti wrote:
On 23/09/14 18:35, Petr Spacek wrote:
On 22.9.2014 19:21, Martin Basti wrote:
On 22/09/14 13:17, Petr Vobornik wrote:
On 19.9.2014 16:15, Martin Basti wrote:
Ticket: https://fedorahosted.org/freeipa/ticket/3414
Patch attached.


Patch 126:

1. I think that just
  DeprecatedParam('dnsclass?'),

should be enough.

Also

2. You forgot to update API.txt and VERSION

Patch 127:
 ACK

Updated patchset attached

ACK, it works for me.

Please don't push, we discuss this and we will nit use the DeprecatedParam.

Updated patch attached

I didn't notice, but changes in VERSION is not required anymore.
Updated patch attached

--
Martin Basti

From 1e7c0f78605b74ad90ab4cc9834dc34272a053a9 Mon Sep 17 00:00:00 2001
From: Martin Basti <mba...@redhat.com>
Date: Thu, 25 Sep 2014 10:55:58 +0200
Subject: [PATCH 1/2] DNS: remove --class option

This option haven't been working, it is time to remove it.

Ticket: https://fedorahosted.org/freeipa/ticket/3414
---
 ipalib/plugins/dns.py | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/ipalib/plugins/dns.py b/ipalib/plugins/dns.py
index e5525018a260d541dca6d71d00719ffbcb6ddc42..64dc6f4bd9e1ed93ac325bf66a2d4859b8b03fb9 100644
--- a/ipalib/plugins/dns.py
+++ b/ipalib/plugins/dns.py
@@ -295,6 +295,7 @@ _zone_top_record_types = ('NS', 'MX', 'LOC', )
 # attributes derived from record types
 _record_attributes = [str('%srecord' % t.lower()) for t in _record_types]
 
+# Deprecated
 # supported DNS classes, IN = internet, rest is almost never used
 _record_classes = (u'IN', u'CS', u'CH', u'HS')
 
@@ -2150,9 +2151,9 @@ class dnszone(DNSZoneBase):
             maxvalue=2147483647, # see RFC 2181
         ),
         StrEnum('dnsclass?',
+            # Deprecated
             cli_name='class',
-            label=_('SOA class'),
-            doc=_('SOA record class'),
+            flags=['no_option'],
             values=_record_classes,
         ),
         Str('idnsupdatepolicy?',
@@ -2594,9 +2595,9 @@ class dnsrecord(LDAPObject):
             doc=_('Time to live'),
         ),
         StrEnum('dnsclass?',
+            # Deprecated
             cli_name='class',
-            label=_('Class'),
-            doc=_('DNS class'),
+            flags=['no_option'],
             values=_record_classes,
         ),
     ) + _dns_record_options
-- 
1.8.3.1

From 0ef0c8395a21daaa19e4419c96ab704b745779dd Mon Sep 17 00:00:00 2001
From: Martin Basti <mba...@redhat.com>
Date: Fri, 19 Sep 2014 16:07:40 +0200
Subject: [PATCH 2/2] WebUI: DNS: remove --class option

Ticket: https://fedorahosted.org/freeipa/ticket/3414
---
 install/ui/src/freeipa/dns.js | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/install/ui/src/freeipa/dns.js b/install/ui/src/freeipa/dns.js
index 3eaad839a8c831b5bf771b870ed2cefd4378c8de..675a2d7e8d2a400df6079ee82e1757c53358cde8 100644
--- a/install/ui/src/freeipa/dns.js
+++ b/install/ui/src/freeipa/dns.js
@@ -154,13 +154,6 @@ return {
                     'idnssoaminimum',
                     'dnsttl',
                     {
-                        $type: 'combobox',
-                        name: 'dnsclass',
-                        options: [
-                            'IN', 'CS', 'CH', 'HS'
-                        ]
-                    },
-                    {
                         $type: 'radio',
                         name: 'idnsallowdynupdate',
                         options: [
-- 
1.8.3.1

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to