Hello! Thanks for the patch!

The new function is not one of the platform-independent tasks, and doesn't even use `self`, so you can define it as a module-level helper function.

But more importantly, this won't work: the blocks you are replacing return from their functions. You'd need to use something like:
    if not selinux_enabled():
        return
instead of:
    self.check_enabled_selinux()

--
PetrĀ³

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to