On 29/09/14 12:57, Martin Kosek wrote:
On 09/29/2014 11:04 AM, David Kupka wrote:
On 09/29/2014 10:22 AM, Martin Kosek wrote:
On 09/29/2014 10:09 AM, David Kupka wrote:
The changes look OK so far, except the test fix.
The test_batch_plugin.py test is apparently testing that batch command behaves
well in RequirementError for options. Thus, we should not remove it, we should
just pick different option. Like filling uid+first options with user-add, but
missing the --last option.
Ok, but the test is bit redundant as there is already test for missing
givenname that should behave the same way.
I think it is useful to keep the test here, in the previous one no option was
Anyway, this should not stop this patch from going in. I checked the test
results + Web UI and all looks OK.
ACK. Pushed to:
Shouldn't be API minor version incremented?
Freeipa-devel mailing list