On 10/06/2014 01:31 PM, Petr Viktorin wrote:
> On 10/03/2014 05:02 PM, Martin Kosek wrote:
> [...]
>>> I like these the best. Maybe with a -to or -by suffix.
>>>
>>>>
>>>> or if we expect more operations in a future:
>>>>
>>>> ipa host-allow-operation HOSTNAME --operation read-keys --users=STR
>>>> --groups STR
>>>> ipa host-disallow-operation HOSTNAME --operation read-keys --users=STR
>>>> --groups STR
>>>> ipa host-allow-operation HOSTNAME --operation write-keys --users=STR
>>>> --groups STR
>>>> ipa host-disallow-operation HOSTNAME --operation write-keys --users=STR
>>>> --groups STR
>>>>
>>>> or if we want to keep 'add' and 'remove' in command names:
>>>>
>>>> ipa host-add-retrieve-keytab-right HOSTNAME --users=STR --groups=STR
>>>> ipa host-add-create-keytab-right HOSTNAME --users=STR --groups=STR
>>>> ipa host-remove-retrieve-keytab-right HOSTNAME --users=STR --groups=STR
>>>> ipa host-remove-create-keytab-right HOSTNAME --users=STR --groups=STR
>>>>
>>>>
>>>> personally I'm not a fan o the --operation switch, but could be
>>>> persuaded by a 'future' usage.
>>>
>>> Not a fan either, because it is not consistent with the rest of the
>>> framework.
>>> Also, non-optional options are not really options.
> 
> To quote optparse docs:
>> If there is a piece of information that your program absolutely  requires
>> in order to run successfully, that’s what positional arguments are for.
> 
> How about something like:
> 
> ipa host-allow-operation HOSTNAME read-keys --users=STR --groups STR
> ipa host-disallow-operation HOSTNAME read-keys --users=STR --groups STR
> ipa host-allow-operation HOSTNAME write-keys --users=STR --groups STR
> ipa host-disallow-operation HOSTNAME write-keys --users=STR --groups STR

Hmm, works for me - from CLI perspective. Not sure though how easy it is to
implement in the current framework. But at least with "takes_args" attribute it
should not be difficult to specify the arguments.

Martin

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to