On Wed, 08 Oct 2014, David Kupka wrote:
On 10/08/2014 08:19 AM, David Kupka wrote:
On 10/08/2014 08:02 AM, Alexander Bokovoy wrote:
On Wed, 08 Oct 2014, David Kupka wrote:
https://fedorahosted.org/freeipa/ticket/4587
--
David Kupka


From 883e90237fbde1075d00990568cde18773e80611 Mon Sep 17 00:00:00 2001
From: David Kupka <dku...@redhat.com>
Date: Wed, 8 Oct 2014 01:43:47 -0400
Subject: [PATCH] Fix example usage in ipa man page.

https://fedorahosted.org/freeipa/ticket/4587
---
ipa.1 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ipa.1 b/ipa.1
index
fc39fceaae5aa4c614ccaaa7e608f2326d926755..6acfcfd9f7ab580c9b086fa249903cdf10544cdb

100644
--- a/ipa.1
+++ b/ipa.1
@@ -149,7 +149,7 @@ Create a new user with username "foo", first name
"foo" and last name "bar".
\fBipa group\-add bar \-\-desc "this is an example group"
Create a new group with name "bar" and description "this is an example
group".
.TP
-\fBipa group\-add\-member bar \-\-users=admin,foo\fR
+\fBipa group\-add\-member bar \-\-users={admin,foo}\fR
Add users "admin" and "foo" to the group "bar".
.TP
\fBipa user\-show foo \-\-raw\fR
I would like to see a stance about shell expansion use here. May be add
a phrase about that right after "Add users ... to the group ..."? It
might not be entirely obvious to other people that we rely on a shell
expansion features here.


At first, I wanted to remove one of users mentioned there but
'--users=foo' looks confusing to me (using plural and specifying just
one value).
Personally I would prefer to change all plural parameters to singular
form but it is a large change considering the benefit.
What about two examples? One '--users=foo' and other using shell expansion.



I forget to update the patch, sorry.

--
David Kupka

From 554d9b0f806f6eb7ad8ffc99fbd7ac6cb20c5c4c Mon Sep 17 00:00:00 2001
From: David Kupka <dku...@redhat.com>
Date: Wed, 8 Oct 2014 01:43:47 -0400
Subject: [PATCH] Fix example usage in ipa man page.

https://fedorahosted.org/freeipa/ticket/4587
---
ipa.1 | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/ipa.1 b/ipa.1
index 
fc39fceaae5aa4c614ccaaa7e608f2326d926755..fe2a1aa7bafadd70596b5d95bca49a3f583a3c3d
 100644
--- a/ipa.1
+++ b/ipa.1
@@ -149,8 +149,11 @@ Create a new user with username "foo", first name "foo" and last 
name "bar".
\fBipa group\-add bar \-\-desc "this is an example group"
Create a new group with name "bar" and description "this is an example group".
.TP
-\fBipa group\-add\-member bar \-\-users=admin,foo\fR
-Add users "admin" and "foo" to the group "bar".
+\fBipa group\-add\-member bar \-\-users=foo\fR
+Add user "foo" to the group "bar".
+.TP
+\fBipa group\-add\-member bar \-\-users={admin,foo}\fR
+Add users "admin" and "foo" to the group "bar". This approach depends on shell 
expansion feature.
.TP
\fBipa user\-show foo \-\-raw\fR
Display user "foo" as (s)he is stored on the server.
ACK.


--
/ Alexander Bokovoy

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to