Dne 14.10.2014 v 15:18 David Kupka napsal(a):
On 10/14/2014 02:28 PM, Jan Cholasta wrote:
Dne 14.10.2014 v 14:19 David Kupka napsal(a):


On 10/14/2014 01:39 PM, Jan Cholasta wrote:
Dne 14.10.2014 v 12:47 David Kupka napsal(a):


On 10/10/2014 03:24 PM, Jan Cholasta wrote:
Dne 8.10.2014 v 12:36 David Kupka napsal(a):
On 10/08/2014 09:29 AM, Jan Cholasta wrote:
Hi,

Dne 8.10.2014 v 09:09 David Kupka napsal(a):
https://fedorahosted.org/freeipa/ticket/4569

In renew_ca_cert and cainstance.py, dogtag should already be
stopped in
the places you modified, so why the change?

I didn't noticed that it is already stopped, fixed.

Also I don't think it's a good idea to backup CS.cfg when dogtag is
still running (in cainstance.py). If the file is being modified by
dogtag at the time it is backed up, the backup may be corrupted.

Fixed, thanks.

CAInstance.backup_config should be called only when Dogtag is
stopped as
well, you don't need to change it.


backup_config is callable from outside of cainstance.py so it's
safer to
check that dogtag is stopped and stop it if necessary. When dogtag is
already stopped it won't do anything.

If dogtag is not stopped in backup_config, it's an error, so an
exception should be raised.

What I meant by this is that you should add this check to backup_config,
because it's not there ATM. Sorry for confusing you.


Ok, hope that I finally understood.


ACK.

--
Jan Cholasta

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to