Change event of combobox is not triggered when there is only one value.
Calling it's handler even for option's 'click' event makes sure that
value of input gets always updated.
--
Petr Vobornik
From 144a808b2d7a0be0aa54439f14e855f09e9b3c57 Mon Sep 17 00:00:00 2001
From: Petr Vobornik <pvobo...@redhat.com>
Date: Mon, 20 Oct 2014 19:10:28 +0200
Subject: [PATCH] webui: update combobox input on list click
Change event of combobox is not triggered when there is only one value. Calling it's handler even for option's 'click' event makes sure that value of input gets always updated.
---
install/ui/src/freeipa/widget.js | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/install/ui/src/freeipa/widget.js b/install/ui/src/freeipa/widget.js
index 39ee19b8dcee1d9001b77af6da0bae1b0a12d7c0..9240df8ef5402310ec9ceafd0b766def10c8cb48 100644
--- a/install/ui/src/freeipa/widget.js
+++ b/install/ui/src/freeipa/widget.js
@@ -3826,10 +3826,13 @@ IPA.combobox_widget = function(spec) {
that.list_on_change = function(e) {
+ var org_val = that.input.val();
var value = that.list.val();
- that.input.val(value);
- that.value_changed.notify([[value]], that);
- that.emit('value-change', { source: that, value: value });
+ if (org_val != value) {
+ that.input.val(value);
+ that.value_changed.notify([[value]], that);
+ that.emit('value-change', { source: that, value: value });
+ }
};
that.list_child_on_blur = function(e) {
@@ -3852,6 +3855,7 @@ IPA.combobox_widget = function(spec) {
// Close list when user selects and option by click
// doesn't work in IE, can be fixed by moving the handler to list.click,
// but it breaks UI automation tests. #3014
+ that.list_on_change();
that.close();
IPA.select_range(that.input, 0, 0);
};
--
1.9.3
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
