On 10/28/2014 10:11 PM, Alexander Bokovoy wrote:
Hi,

two patches to slapi-nis are attached:

- make sure only DNs from the schema-compat trees are targeted for ID
view replacement. This solves issue of https://bugzilla.redhat.com/show_bug.cgi?id=1157989
 found by Sumit.

- support ID overrides in the BIND callback. So far the only thing we
 need is overriding uid.

They need to be applied in this order, on top of 0.54 release version of
slapi-nis.



_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
Hi Alexander,

The patches fixed the test case in https://bugzilla.redhat.com/show_bug.cgi?id=1157989.
Few comments regarding the patch:

 * in backend_search_cb, it checks if the search is in one of the
   container. We need that cbdata.answer=FALSE at the end of the checking.
   Why not setting it systematically at the end.
 * in backend_locate, 'target' is a duplicate of cbdata.target. But
   then when calling idview_replace_target_dn it may be changed.
   Will not it lead to a leak ?


Thanks
thierry

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to