On [Tue, 11.11.2014 13:57], Martin Basti wrote:
On 11/11/14 13:37, Thorsten Scherf wrote:
The ipa-server-install man page is more descriptive on how to configure
multiple DNS forwarders than the cli help. The cli help is more verbose
now.

https://fedorahosted.org//ticket/4465

Cheers,
Thorsten


Hello,

thanks for patch, but I have a few objections.

1) Trac link in commit is corrupted
2) The forwarder option is in more installation scripts:
* ipa-dns-install
* ipa-replica-install
* ipa-server-install

Please find the new patch attached.

https://fedorahosted.org/freeipa/ticket/4465

Cheers,
Thorsten


From 64faa16b953190d60e06598eeceef928afeaefe3 Mon Sep 17 00:00:00 2001
From: Thorsten Scherf <[email protected]>
Date: Tue, 11 Nov 2014 15:38:01 +0100
Subject: [PATCH] Add help string on how to configure multiple DNS forwards for
 various cli tools

The man pages for various FreeIPA setup tools are more descriptive on how to
configure multiple DNS forwarders than the corresponding cli help. This patch
makes the cli help more verbose now for the following tools:

* ipa-dns-install
* ipa-replica-install
* ipa-server-install

https://fedorahosted.org/freeipa/ticket/4465
---
 install/tools/ipa-dns-install     | 2 +-
 install/tools/ipa-replica-install | 2 +-
 install/tools/ipa-server-install  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/install/tools/ipa-dns-install b/install/tools/ipa-dns-install
index 
73afadf56a1b6594d11fd87b0efdeb6cc179bc0d..7d9bf6a8b223b586e7923137abec557036f650da
 100755
--- a/install/tools/ipa-dns-install
+++ b/install/tools/ipa-dns-install
@@ -47,7 +47,7 @@ def parse_options():
                       default=[], action="append",
                       type="ip", ip_local=True, help="Master Server IP 
Address")
     parser.add_option("--forwarder", dest="forwarders", action="append",
-                      type="ip", help="Add a DNS forwarder")
+                      type="ip", help="Add a DNS forwarder. This option can be 
used multiple times")
     parser.add_option("--no-forwarders", dest="no_forwarders", 
action="store_true",
                       default=False, help="Do not add any DNS forwarders, use 
root servers instead")
     parser.add_option("--reverse-zone", dest="reverse_zones",
diff --git a/install/tools/ipa-replica-install 
b/install/tools/ipa-replica-install
index 
8f0ce86667b3603cb2a72fbc9b78e074db73cdd9..409f1f61b42ccb2a4f2053689a7452f4fe344b4d
 100755
--- a/install/tools/ipa-replica-install
+++ b/install/tools/ipa-replica-install
@@ -109,7 +109,7 @@ def parse_options():
     dns_group.add_option("--setup-dns", dest="setup_dns", action="store_true",
                       default=False, help="configure bind with our zone")
     dns_group.add_option("--forwarder", dest="forwarders", action="append",
-                      type="ip", help="Add a DNS forwarder")
+                      type="ip", help="Add a DNS forwarder. This option can be 
used multiple times")
     dns_group.add_option("--no-forwarders", dest="no_forwarders", 
action="store_true",
                       default=False, help="Do not add any DNS forwarders, use 
root servers instead")
     dns_group.add_option("--reverse-zone", dest="reverse_zones", default=[],
diff --git a/install/tools/ipa-server-install b/install/tools/ipa-server-install
index 
cb79cfbbc09966950f4e5fb51984008b20600143..1280b631db4f7b6ad69d1151d047a8190ca5215a
 100755
--- a/install/tools/ipa-server-install
+++ b/install/tools/ipa-server-install
@@ -282,7 +282,7 @@ def parse_options():
     dns_group.add_option("--setup-dns", dest="setup_dns", action="store_true",
                       default=False, help="configure bind with our zone")
     dns_group.add_option("--forwarder", dest="forwarders", action="append",
-                      type="ip", help="Add a DNS forwarder")
+                      type="ip", help="Add a DNS forwarder. This option can be 
used multiple times")
     dns_group.add_option("--no-forwarders", dest="no_forwarders", 
action="store_true",
                       default=False, help="Do not add any DNS forwarders, use 
root servers instead")
     dns_group.add_option("--reverse-zone", dest="reverse_zones", help="The 
reverse DNS zone to use",
-- 
1.9.3

Attachment: pgpXYQOW7Psbi.pgp
Description: PGP signature

_______________________________________________
Freeipa-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to