On 18/11/14 22:01, Martin Kosek wrote:
On 11/18/2014 08:20 PM, Martin Basti wrote:
Ticket: https://fedorahosted.org/freeipa/ticket/4676

Attached patches:

* Version A: uses wget to get status of CA
* Version B: write warning instead of raising exception (error is false
positive, CA is running)

I'm open to suggestions which approach is better

Martin^2


I like A, but I am concerned why you suddenly ignore the use_proxy option. I added it for a reason as it affects to which port we need to connect, regardless the transport library. See

https://fedorahosted.org/freeipa/ticket/3973

where I added this option.

Second, I am not happy by you duplicating the XML parsing code, I would rather see it splited in dogtag.py in separate "_ca_status_parse" or similar function call.

Given the obstacles, I am inclining for
- pushing B as a safe fix for Fedora 21 Final
- fixing issues in A and pushing it for minor release after that to avoid the nasty warning and have some reasonable medium-term fix until the framework migrates to something better than httpslib, line python-requests maybe.

Martin
Sounds good to me.

Patch required for F21 attached. (with proper number)
I will send the second patch after release for fedora (or should I sooner?)
Martin^2

--
Martin Basti

From 61508160f5ce2947c78a4e1fd1319ddee538b7bc Mon Sep 17 00:00:00 2001
From: Martin Basti <mba...@redhat.com>
Date: Tue, 18 Nov 2014 18:30:59 +0100
Subject: [PATCH] Show warning instead of error if CA did not start

This is just workaround, checking if CA is working raises false positive
exception during upgrade

Ticket: https://fedorahosted.org/freeipa/ticket/4676
---
 install/tools/ipa-upgradeconfig | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/install/tools/ipa-upgradeconfig b/install/tools/ipa-upgradeconfig
index b81a474b2bb14f1582dabd649400c13f7ce6d369..02bfe3a79f83e65f428fe2220d940eb39fdbd928 100644
--- a/install/tools/ipa-upgradeconfig
+++ b/install/tools/ipa-upgradeconfig
@@ -1473,6 +1473,10 @@ def main():
             ca.restart(dogtag.configured_constants().PKI_INSTANCE_NAME)
         except ipautil.CalledProcessError, e:
             root_logger.error("Failed to restart %s: %s", ca.service_name, e)
+        # FIXME https://fedorahosted.org/freeipa/ticket/4676
+        # workaround
+        except RuntimeError as e:
+            root_logger.warning(str(e))
 
     set_sssd_domain_option('ipa_server_mode', 'True')
 
-- 
1.8.3.1

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to