On 12/04/2014 07:15 PM, Nathaniel McCallum wrote:
On Thu, 2014-12-04 at 14:56 +0100, Petr Vobornik wrote:
On 2.12.2014 20:57, Nathaniel McCallum wrote:



Works fine.

python part of 0004: ACK, but VERSION needs to be updated before push
0005: ACK

Fixed and rebased. Patch numbers have changed:
0004 => 0001
0005 => 0002

One question before push: For per-token configuration, do you intent to
extend each token, regardless of type, by 'ipatokenOTPConfig' object
class? I.e. to have config attributes for both types? Or do you plan to
have special object classes for each token type as we now have for tokens?

I would probably just add the TOTP options to the ipatokenTOTP object
class as MAY. Same for HOTP. The attributes were designed to look like
the other token-type-specific attributes.

I think we are just waiting on Thierry's review of the C code. :)

Thierry already wrote:

regarding the DS plugin part of 0004, the patch is good to  me. For the ipa 
plugins part I am too novice.

Therefore:

0001 Pushed to:
master: 9baa93da1cbf56c2a6f7e82e099bc3ff3f19e2e4
ipa-4-1: 3013385ca4a28a4f203fae6dbef34321720d8879

0002 Pushed to:
ipa-4-1: f5ae902eb5c391bd6150c99d5b3316be937aa459
master: b01767c69d69806b3c701242d617b6fa08e7d882


Nathaniel

--
Petr Vobornik

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to