On 13.1.2015 10:57, Martin Kosek wrote: > On 01/13/2015 10:16 AM, Petr Spacek wrote: >> Hello, >> >> Fix default value type for wait_for_dns option >> >> wait_for_dns value should be an integer so default value was changed from >> False to 0. >> > > Thanks. I stumbled on this value this morning, when setting it to True did not > work. > > IMO, it would make sense to even rename the option to something that does not > indicate boolean semantics, like "dns_wait_retry_attempts" or similar. But it > may be too disruptive as at least our CI scripts would have to be updated. > > Up to you.
Well, open a ticket for option rename :-) Anyway, this change can be pushed as-is (after review) even if we decide to rename it later. -- Petr^2 Spacek _______________________________________________ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
