On 08/01/15 09:43, Martin Basti wrote:
On 16/12/14 13:04, Martin Basti wrote:
On 16/12/14 13:00, Martin Kosek wrote:
On 12/16/2014 12:30 PM, Martin Basti wrote:
On 11/12/14 12:13, Martin Basti wrote:
On 11/12/14 11:19, Jan Cholasta wrote:
Hi,
Dne 9.12.2014 v 16:07 Martin Basti napsal(a):
Ticket: https://fedorahosted.org/freeipa/ticket/4793
I'm able to reproduce it only in one nose test.
Which test?
If you apply my patch 170 and add a random forwardzone, then DNS
root zone
tests failed.
Patch attached.
What about:
result['messages'] = result.get('messages', ()) +
(message.to_dict(),)
(My point is, don't support both lists and tuples, pick just one.)
Honza
This is question for framework guru (you?), I tried to preserve
format
unchanged.
Shouldn't be all values in lists in server part?
Martin^2
As was requested, I convert tuple to list instead handling both types.
Updated patch attached.
I assume you do not want to track the .idea/ files in FreeIPA git :-)
Oh, thanks. My IDE was too smart again and add those files there itself.
updated patch attached
Please review this patch.
Modified patch attached.
Message should be added only on server side
--
Martin Basti
From 6e37f13682ff25ae72e027b79151107033d92be1 Mon Sep 17 00:00:00 2001
From: Martin Basti <mba...@redhat.com>
Date: Tue, 16 Dec 2014 13:02:12 +0100
Subject: [PATCH] Fix warning message on client side
Add message about only on server side.
https://fedorahosted.org/freeipa/ticket/4793
---
ipalib/frontend.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/ipalib/frontend.py b/ipalib/frontend.py
index a9a3dfeaac2ab7047c036ea7bbed7655dd93be56..98070b8433325b9ef30ebc1c3a30a92b772d31d5 100644
--- a/ipalib/frontend.py
+++ b/ipalib/frontend.py
@@ -437,7 +437,9 @@ class Command(HasParam):
self.validate(**params)
(args, options) = self.params_2_args_options(**params)
ret = self.run(*args, **options)
- if not version_provided and isinstance(ret, dict):
+ if (not version_provided and isinstance(ret, dict) and
+ self.api.env.in_server):
+ # add message only on server side
messages.add_message(
API_VERSION, ret,
messages.VersionMissing(server_version=API_VERSION))
--
2.1.0
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel