Hi,

Dne 12.1.2015 v 13:11 Martin Basti napsal(a):
Part of DNSSEC (https://fedorahosted.org/freeipa/ticket/4657)

Patch attached.

1) In P11_Helper_set_attribute, the return value can be only Py_None or NULL, so why don't you use Py_XINCREF instead of the if/Py_INCREF?

2) In P11_Helper_find_keys, you sometimes return without decreasing reference count on result_list or any items it may contain.

Honza

--
Jan Cholasta

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to